[Solved] Revised backlight modes

Discussions related to the firmware code development
Post Reply
oh4va
Posts: 25
Joined: Sat Mar 07, 2020 7:14 am

[Solved] Revised backlight modes

Post by oh4va » Sat Apr 04, 2020 1:10 pm

Hi all,

This was a very interesting embedded system project. I jumped in revising the backlight modes to be more intuitive for a new user like me. The modes are: On, Off, Manual, Auto. In the manual mode the backlight is toggled in three states Off --> On --> Dimmed --> Off.

If someone is interested the code is in a forked repository devel branch at at https://github.com/oh4va/OpenGD77/

73 de Veijo OH4VA
Last edited by oh4va on Tue Apr 07, 2020 6:47 am, edited 5 times in total.

kt4lh
Posts: 272
Joined: Sun Jan 12, 2020 4:27 am

Re: Revised backlight modes

Post by kt4lh » Sat Apr 04, 2020 3:47 pm

So you added Mode "On" to replace Timeout: "No" ?

oh4va
Posts: 25
Joined: Sat Mar 07, 2020 7:14 am

Re: Revised backlight modes

Post by oh4va » Sat Apr 04, 2020 3:48 pm

kt4lh wrote:
Sat Apr 04, 2020 3:47 pm
So you added Mode "On" to replace Timeout: "No" ?
Yes, I did.

Edit: If you try this firmware reset the radio after installation (press blue btn + power up)

73 de VA

oh4va
Posts: 25
Joined: Sat Mar 07, 2020 7:14 am

Re: Revised backlight modes

Post by oh4va » Sat Apr 04, 2020 9:18 pm

Edit: Not relevant anymore.
Last edited by oh4va on Tue Apr 07, 2020 4:53 am, edited 2 times in total.

User avatar
F1RMB
Posts: 2518
Joined: Sat Nov 16, 2019 5:42 am
Location: Grenoble, France

Re: Revised backlight modes

Post by F1RMB » Sat Apr 04, 2020 9:35 pm

oh4va wrote:
Sat Apr 04, 2020 9:18 pm
VK3KYY wrote:
Sat Apr 04, 2020 8:49 pm
What’s wrong with the backlight modes?
Usability!
No!
oh4va wrote:
Sat Apr 04, 2020 9:18 pm
VK3KYY wrote:
Sat Apr 04, 2020 8:49 pm
Is it that you don’t like the Timeout of zero to mean no timeout.
I.e do you think timeout of zero should display “Timeout:Never” ?
I am not sure if this is possible because of problems with translation text lengths
Have you even read my code or tested the built firmware? I guess not. This modification has nothing to do with the language translations. The text is Timeout:5s to 30s, there is no need to translate the seconds.
Read above.
oh4va wrote:
Sat Apr 04, 2020 9:18 pm
VK3KYY wrote:
Sat Apr 04, 2020 8:49 pm
You can of course do a special version for yourself, as the 1000+ other users seem OK with the current system
Let's do so...

73 de VA
Have fun.

73.

KC7RBW
Posts: 159
Joined: Wed Nov 20, 2019 1:23 am

Re: Revised backlight modes

Post by KC7RBW » Sun Apr 05, 2020 3:12 am

Hi VA,

Don't let these guys discourage you. I think this change you made is more intuitive than how it works right now (though I think I would have put On as the first option). Most of my own patches still make sense to me too. Only one or two, plus some documentation updates, have been accepted so far. I keep the rest of them in my clone and rebase them when I want to see if they still make sense or if I've thought better of them.

Keep in mind that everything about how the firmware works today seemed like the right way to someone. It's hard to please everyone, and what seems intuitive to you or I may seem the opposite to someone who's used to something else.

Successful Open Source communities thrive on smaller contributions. Keep up the good work.

BTW, to avoid corruption when making changes to the nonvolatile settings you can change the magic number to something random for test firmwares. It basically just forces a reset, but in the future it could be used to upgrade the settings from one format to the next.

Kind Regards,
Andrew / KC7RBW

OH7FES
Posts: 13
Joined: Sun Mar 01, 2020 5:32 pm
Location: Lieksa Finland
Contact:

Re: Revised backlight modes

Post by OH7FES » Sun Apr 05, 2020 4:29 am

Hello OH4VA
Thanks for OH4VA backlight fix. Now both Auto and Manual mode work really well, WHEN the Min bright setting is 1%, now Manual setting backlight can be turned off.
73 OH7FES Ari

oh4va
Posts: 25
Joined: Sat Mar 07, 2020 7:14 am

Re: Revised backlight modes

Post by oh4va » Wed Apr 08, 2020 5:13 am

Hi,

I introduced a new page for my modifications, viewtopic.php?f=15&t=815

73 de Veijo OH4VA (aka OH3NFC)
Last edited by oh4va on Wed Apr 08, 2020 8:07 am, edited 1 time in total.

VK3KYY
Posts: 7481
Joined: Sat Nov 16, 2019 3:25 am
Location: Melbourne, Australia

Re: Revised backlight modes

Post by VK3KYY » Wed Apr 08, 2020 5:50 am

Daniel's fix for the bug in the backlight will be in the next pre-release version, which will probably be posted to the forumthis weekend, or possibly before , if i have time.

Post Reply