Disable Private Call notification for special IDs
Disable Private Call notification for special IDs
Some people reported problems with the Private Call alert, which I originally did not understand
However I now see that Brandmeister seems to reply to TG calls on reflectors by sending back a Private Call and this triggers the firmware to go into Private Call accept mode.
Looking at what BM replies, it sends replies from the ID number which is the same as the Reflector TG number and also seems to send the users own ID as the Talkgroup.
So.. I've put in a fix for this, by checking if the ID of the sender (BM) is equal to the TG you just transmitted on, and to then ignore it as a Private Call because its a special BM private call.
Hopefully this will solve some of the Private Call alert problems that some people have been reporting
However I now see that Brandmeister seems to reply to TG calls on reflectors by sending back a Private Call and this triggers the firmware to go into Private Call accept mode.
Looking at what BM replies, it sends replies from the ID number which is the same as the Reflector TG number and also seems to send the users own ID as the Talkgroup.
So.. I've put in a fix for this, by checking if the ID of the sender (BM) is equal to the TG you just transmitted on, and to then ignore it as a Private Call because its a special BM private call.
Hopefully this will solve some of the Private Call alert problems that some people have been reporting
- Attachments
-
[The extension sgl has been deactivated and can no longer be displayed.]
Re: Disable Private Call notification for special IDs
I tried, but the problem is still there. Watch the video clip I made.
https://drive.google.com/open?id=14N_a- ... 0-feahzWen
https://drive.google.com/open?id=14N_a- ... 0-feahzWen
Re: Disable Private Call notification for special IDs
Ok.
I will watch the video. Perhaps there is some difference between BM servers
I will watch the video. Perhaps there is some difference between BM servers
Re: Disable Private Call notification for special IDs
I can not understand what you were doingIU4LEG wrote: ↑Mon Dec 02, 2019 11:28 amI tried, but the problem is still there. Watch the video clip I made.
https://drive.google.com/open?id=14N_a- ... 0-feahzWen
What TG or PC is the channel you were using ?
e.g. Is it someone's PC or your PC or a TG ??
Re: Disable Private Call notification for special IDs
Hi Roger,
I was calling a private contact IZ4RCU, when I release the ptt the repeater returns a signal with my call IU4LEG as a private call. a kind of echo. this happens on all repeaters, not just on the brandmeister network.
I was calling a private contact IZ4RCU, when I release the ptt the repeater returns a signal with my call IU4LEG as a private call. a kind of echo. this happens on all repeaters, not just on the brandmeister network.
Re: Disable Private Call notification for special IDs
Roger,
I have just tested this.
The current firmware is incorrectly responding to a private call to any ID and displaying the 'Accept Call' prompt. It should only be triggered by a private call to its own ID. I looks like there is no filtering to test if the destination ID is the radios ID.
What IU4LEG is seeing is the repeated packets of his own private call to the other station due to the delay in the repeater. The radio is seeing this as an incoming call and because there is no filtering on the destination ID it is triggering the 'Accept Call' message.
Colin.
I have just tested this.
The current firmware is incorrectly responding to a private call to any ID and displaying the 'Accept Call' prompt. It should only be triggered by a private call to its own ID. I looks like there is no filtering to test if the destination ID is the radios ID.
What IU4LEG is seeing is the repeated packets of his own private call to the other station due to the delay in the repeater. The radio is seeing this as an incoming call and because there is no filtering on the destination ID it is triggering the 'Accept Call' message.
Colin.
Re: Disable Private Call notification for special IDs
Colin
Ok.
I will change the call accept code to check the users own Id
Ok.
I will change the call accept code to check the users own Id
Re: Disable Private Call notification for special IDs
Hi Roger,
I think we overlapped. I have just submitted a PR which should fix this. It works for me on my repeater and on Simplex private calls.
Colin.
I think we overlapped. I have just submitted a PR which should fix this. It works for me on my repeater and on Simplex private calls.
Colin.
Re: Disable Private Call notification for special IDs
Thanks
I've merged the PR
I've merged the PR