Disable Private Call notification for special IDs

Post Reply
VK3KYY
Posts: 7478
Joined: Sat Nov 16, 2019 3:25 am
Location: Melbourne, Australia

Disable Private Call notification for special IDs

Post by VK3KYY » Mon Dec 02, 2019 10:39 am

Some people reported problems with the Private Call alert, which I originally did not understand

However I now see that Brandmeister seems to reply to TG calls on reflectors by sending back a Private Call and this triggers the firmware to go into Private Call accept mode.

Looking at what BM replies, it sends replies from the ID number which is the same as the Reflector TG number and also seems to send the users own ID as the Talkgroup.

So.. I've put in a fix for this, by checking if the ID of the sender (BM) is equal to the TG you just transmitted on, and to then ignore it as a Private Call because its a special BM private call.

Hopefully this will solve some of the Private Call alert problems that some people have been reporting
Attachments

[The extension sgl has been deactivated and can no longer be displayed.]


User avatar
m1dyp
Posts: 601
Joined: Sat Nov 16, 2019 8:03 am
Location: Hertfordshire, U.K.
Contact:

Re: Disable Private Call notification for special IDs

Post by m1dyp » Mon Dec 02, 2019 11:20 am

thank you

User avatar
IU4LEG
Posts: 191
Joined: Wed Nov 20, 2019 12:49 pm

Re: Disable Private Call notification for special IDs

Post by IU4LEG » Mon Dec 02, 2019 11:28 am

I tried, but the problem is still there. Watch the video clip I made.

https://drive.google.com/open?id=14N_a- ... 0-feahzWen

VK3KYY
Posts: 7478
Joined: Sat Nov 16, 2019 3:25 am
Location: Melbourne, Australia

Re: Disable Private Call notification for special IDs

Post by VK3KYY » Mon Dec 02, 2019 7:56 pm

Ok.

I will watch the video. Perhaps there is some difference between BM servers

VK3KYY
Posts: 7478
Joined: Sat Nov 16, 2019 3:25 am
Location: Melbourne, Australia

Re: Disable Private Call notification for special IDs

Post by VK3KYY » Mon Dec 02, 2019 8:28 pm

IU4LEG wrote:
Mon Dec 02, 2019 11:28 am
I tried, but the problem is still there. Watch the video clip I made.

https://drive.google.com/open?id=14N_a- ... 0-feahzWen
I can not understand what you were doing

What TG or PC is the channel you were using ?

e.g. Is it someone's PC or your PC or a TG ??

User avatar
IU4LEG
Posts: 191
Joined: Wed Nov 20, 2019 12:49 pm

Re: Disable Private Call notification for special IDs

Post by IU4LEG » Tue Dec 03, 2019 2:37 pm

Hi Roger,
I was calling a private contact IZ4RCU, when I release the ptt the repeater returns a signal with my call IU4LEG as a private call. a kind of echo. this happens on all repeaters, not just on the brandmeister network.

G4EML
Posts: 919
Joined: Sat Nov 16, 2019 10:01 am

Re: Disable Private Call notification for special IDs

Post by G4EML » Tue Dec 03, 2019 5:32 pm

Roger,

I have just tested this.

The current firmware is incorrectly responding to a private call to any ID and displaying the 'Accept Call' prompt. It should only be triggered by a private call to its own ID. I looks like there is no filtering to test if the destination ID is the radios ID.

What IU4LEG is seeing is the repeated packets of his own private call to the other station due to the delay in the repeater. The radio is seeing this as an incoming call and because there is no filtering on the destination ID it is triggering the 'Accept Call' message.

Colin.

VK3KYY
Posts: 7478
Joined: Sat Nov 16, 2019 3:25 am
Location: Melbourne, Australia

Re: Disable Private Call notification for special IDs

Post by VK3KYY » Tue Dec 03, 2019 7:44 pm

Colin

Ok.

I will change the call accept code to check the users own Id

G4EML
Posts: 919
Joined: Sat Nov 16, 2019 10:01 am

Re: Disable Private Call notification for special IDs

Post by G4EML » Tue Dec 03, 2019 8:39 pm

Hi Roger,

I think we overlapped. I have just submitted a PR which should fix this. It works for me on my repeater and on Simplex private calls.

Colin.

VK3KYY
Posts: 7478
Joined: Sat Nov 16, 2019 3:25 am
Location: Melbourne, Australia

Re: Disable Private Call notification for special IDs

Post by VK3KYY » Tue Dec 03, 2019 8:57 pm

Thanks

I've merged the PR

Post Reply