Manual Display Toggle

Post Reply
NA7Q
Posts: 81
Joined: Wed Jan 01, 2020 3:41 pm

Manual Display Toggle

Post by NA7Q » Sun Jan 12, 2020 4:12 pm

I use the latest source with my own builds. I just happened to notice a bug with the manual display mode caused by the number key functions. It's on line 377 of the fw_main.c. I could be wrong and be missing something, but this change fixes it for me.
If this is not an appropriate place for this thread. Please move it. Thanks.

https://github.com/rogerclarkmelbourne/ ... /pull/342

Code: Select all

if ((nonVolatileSettings.backlightMode == BACKLIGHT_MODE_MANUAL) && (KEYCHECK_DOWN(keys,KEY_SK1)))
This should be reverted to..

Code: Select all

if ((nonVolatileSettings.backlightMode == BACKLIGHT_MODE_MANUAL) && (buttons == BUTTON_SK1))

DL4LEX
Posts: 61
Joined: Sat Nov 16, 2019 3:09 pm

Re: Manual Display Toggle

Post by DL4LEX » Sun Jan 12, 2020 4:47 pm

Could you describe the bug?
Alex DL4LEX

VK3KYY
Posts: 1611
Joined: Sat Nov 16, 2019 3:25 am
Location: Melbourne, Australia
Contact:

Re: Manual Display Toggle

Post by VK3KYY » Sun Jan 12, 2020 10:22 pm

Alex

BTW.
Daniel also told me about a bug during scanning which is probably caused by the same changes in the code, but I don't have details of this bug.

DL4LEX
Posts: 61
Joined: Sat Nov 16, 2019 3:09 pm

Re: Manual Display Toggle

Post by DL4LEX » Mon Jan 13, 2020 2:14 am

Ok, I changed it to make long press on buttons available by including the buttons into the keypad code.
But the seems to make more problems. And we don't need all the possibilities of the keypad for the buttons.

I will revert this and make a PR (on Wednesday) together with some code to prepare reading the button functions from codeplug.

The fix from NA7Q is correct for now.
Alex DL4LEX

VK3KYY
Posts: 1611
Joined: Sat Nov 16, 2019 3:25 am
Location: Melbourne, Australia
Contact:

Re: Manual Display Toggle

Post by VK3KYY » Mon Jan 13, 2020 2:21 am

DL4LEX wrote:
Mon Jan 13, 2020 2:14 am
Ok, I changed it to make long press on buttons available by including the buttons into the keypad code.
But the seems to make more problems. And we don't need all the possibilities of the keypad for the buttons.

I will revert this and make a PR (on Wednesday) together with some code to prepare reading the button functions from codeplug.

The fix from NA7Q is correct for now.
Thanks

NA7Q
Posts: 81
Joined: Wed Jan 01, 2020 3:41 pm

Re: Manual Display Toggle

Post by NA7Q » Mon Jan 13, 2020 3:27 am

I guess I forgot to mention the issue there. The problem is that it wouldn't activate the display by short pressing the key.

Thanks again!

Post Reply